Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @optuna/types and @optuna/storage #848

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Create @optuna/types and @optuna/storage #848

merged 6 commits into from
Mar 27, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Mar 22, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Create @optuna/types and @optuna/storage-loader

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.51%. Comparing base (7cb89d7) to head (978695b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   69.51%   69.51%           
=======================================
  Files          35       35           
  Lines        2375     2375           
=======================================
  Hits         1651     1651           
  Misses        724      724           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata changed the title Create @optuna/types and @optuna/storage-loader Create @optuna/types and @optuna/storage Mar 22, 2024
@c-bata c-bata marked this pull request as ready for review March 22, 2024 10:49
@c-bata
Copy link
Member Author

c-bata commented Mar 27, 2024

@porink0424 Could you review this PR?

Copy link
Collaborator

@porink0424 porink0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@c-bata c-bata merged commit a228382 into optuna:main Mar 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants