Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented tests for @optuna/react #860

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Implemented tests for @optuna/react #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
12784c3
Fix bug regarding NaN, Infinity, -Infinity in loadJournalStorage
porink0424 Apr 3, 2024
7ae1e4f
Replace null -> undefined in trial.values to support type
porink0424 Apr 5, 2024
bcc1981
Add generate_assets script for testing @optuna/react
porink0424 Apr 5, 2024
38b64c7
Impl test by vitest for components
porink0424 Apr 5, 2024
28c865d
Impl test by toBeInTheDocument()
porink0424 Apr 5, 2024
0396537
Add tests for tslib/react
porink0424 Apr 5, 2024
ac20f25
Apply formatter
porink0424 Apr 5, 2024
aa9c2a8
Apply fmt
porink0424 Apr 10, 2024
2f135be
Fix typo
porink0424 Apr 10, 2024
de0accd
Improve test message: replace study_id -> study_name
porink0424 Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/typescript-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,33 @@ jobs:
python-version: '3.11'
architecture: x64

- name: Generate test asset
- name: Generate test asset for storage
working-directory: tslib/storage/test/
run: |
python -m pip install --progress-bar off --upgrade pip setuptools
pip install --progress-bar off optuna
python generate_assets.py

- name: Generate test asset for react
working-directory: tslib/react/test/
run: |
python generate_assets.py

- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: '20'
cache: 'npm'

- name: Build test
run: make tslib
- name: Run tslib test

- name: Run tslib test for storage
working-directory: tslib/storage
run: |
npm run test

- name: Run tslib test for react
working-directory: tslib/react
run: |
npm run test
7 changes: 6 additions & 1 deletion standalone_app/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading