Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type-checks on standalone_app #884

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add type-checks on standalone_app #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bb76da
Add type-check on standalone_app as run script
porink0424 May 31, 2024
994587f
Add running type-check in typescript-tests workflow
porink0424 May 31, 2024
4f19f44
Add building rustlib process before type-check for standalone_app
porink0424 May 31, 2024
da5f81d
Install wasm-pack before building rustlib
porink0424 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/typescript-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- run: npm run lint

type-check:
name: Type checking on optuna-dashboard
name: Type checking on optuna-dashboard & standalone_app
runs-on: ubuntu-latest

steps:
Expand All @@ -44,12 +44,24 @@ jobs:
- name: Setup tslib
run: make tslib

- name: Type Check
- name: Type Check optuna_dashboard
working-directory: optuna_dashboard
run: |
npm install
npm run type-check

- name: Build rustlib for standalone_app
working-directory: rustlib
run: |
curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
wasm-pack build --target web

- name: Type Check standalone_app
working-directory: standalone_app
run: |
npm install
npm run type-check

check-package-lock-json:
name: Check package-lock.json
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion standalone_app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"description": "",
"scripts": {
"watch": "vite",
"build:vscode": "webpack"
"build:vscode": "webpack",
"type-check": "tsc --noEmit"
},
"devDependencies": {
"@optuna/types": "../tslib/types",
Expand Down