Address comments by Alnusjaponica

optuna · Nov 6, 2023 · de32944 · de32944
1 parent 0d8ab14
commit de32944
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/multi_objective/quadratic_simple.py b/multi_objective/quadratic_simple.py
@@ -2,8 +2,8 @@
 Optuna example that optimizes simple quadratic functions.
 
 In this example, we optimize two objective values.
-Unlike a single-objective optimization, an optimization gives the trade-off between two objectives.
-As a result, we get best trade-offs between two objectives, a.k.a Pareto solutions.
+Unlike single-objective optimization, an optimization gives a trade-off between two objectives.
+As a result, we get the best trade-offs between two objectives, a.k.a Pareto solutions.
 
 """
 

diff --git a/quadratic_simple_constraint.py b/quadratic_simple_constraint.py
@@ -46,15 +46,15 @@ def constraints(trial):
 
     print("Number of finished trials: ", len(study.trials))
 
-    feasible_trial_ids = [
+    feasible_trial_numbers = [
         trial.number
         for trial in study.trials
         if all(c <= 0.0 for c in trial.system_attrs["constraints"])
     ]
-    if len(feasible_trial_ids) == 0:
+    if len(feasible_trial_numbers) == 0:
         print("No trials satisfied all the constraints.")
     else:
-        best_trial_id = sorted(feasible_trial_ids, key=lambda i: study.trials[i].value)[0]
+        best_trial_id = sorted(feasible_trial_numbers, key=lambda i: study.trials[i].value)[0]
         best_trial = study.trials[best_trial_id]
         print(f"Best trial was found at Trial#{best_trial_id}")
         print(f"  Params: {best_trial.params}")