Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run DaskML example with Python 3.11 #188

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented May 4, 2023

Motivation

Run DaskML example with Python 3.11 for #164.

Description of the changes

Add python 3.11 to python-version matrix.

@nzw0301 nzw0301 changed the title Add python 3.11 to dask_ml CI Run DaskML example with Python 3.11 May 4, 2023
@toshihikoyanase
Copy link
Member

Thank you for your PR. The CI worked as expected, but Python 3.11 support of dask-ml seems to be work-in-progress according to dask/dask-ml#970.

@github-actions
Copy link

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label May 17, 2023
@github-actions
Copy link

This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely.

@github-actions github-actions bot closed this May 31, 2023
@toshihikoyanase
Copy link
Member

The DaskML members are still working on the support for Python 3.11, so let me reopen this PR.
dask/dask-ml#970 (comment)

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Jun 1, 2023
@github-actions
Copy link

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jun 11, 2023
@toshihikoyanase
Copy link
Member

dask/dask-ml#970 is still ongoing.

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Jun 22, 2023
@not522
Copy link
Member

not522 commented Jun 26, 2023

@toshihikoyanase Could you continue the review as the assignee?

@toshihikoyanase
Copy link
Member

@not522 Thanks for letting me know. The Dask-ml's official support for Python 3.11 may still take some time, but the features required by the Optuna example have already worked. So, let me introduce the change in this PR.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the CI fails, we'll just roll back the change.

@toshihikoyanase toshihikoyanase merged commit 7be5727 into optuna:main Jun 26, 2023
12 checks passed
@not522 not522 added this to the v3.3.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants