Add Dask example #46
Add Dask example #46
Conversation
| import optuna | ||
|
|
||
| import dask.array as da |
There was a problem hiding this comment.
This change is to avoid an isort error in the dask-ml example, though I'm not sure why this didn't appear over in #45
|
This pull request has not seen any recent activity. |
|
This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely. |
|
Similar to optuna/optuna#2023, I'd like to pick this PR back up but don't see the "Reopen pull request" button in the GitHub UI. Could someone reopen this PR for me? (maybe @nzw0301 can since they were the one who reopened optuna/optuna#2023?) |
|
@jrbourbeau I've reopened this PR. Thank you for your huge effort. I'll review optuna/optuna#2023 within a week 🙇 |
|
Thanks @c-bata! |
|
This pull request has not seen any recent activity. |
|
This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely. |
|
This pull request has not seen any recent activity. |
There was a problem hiding this comment.
LGTM! Let me merge this PR after optuna/optuna#2023 is merged.
c-bata
added
the
feature
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ['3.7', '3.8', '3.9', '3.10'] |
There was a problem hiding this comment.
having python 3.7 wouldn't be a problem for certain versions of dask?
There was a problem hiding this comment.
No it shouldn't be an issue. It will cause an older version of distributed to get pulled in, but optuna/optuna#2023 doesn't use any new distributed features so is backwards compatible back to Python 3.7. Note that optuna/optuna#2023 has Python 3.7 CI builds
There was a problem hiding this comment.
@jrbourbeau I merged optuna/optuna#2023, so could you update the URL?
.github/workflows/dask.yml
Outdated
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install --progress-bar off -U setuptools | ||
| pip install git+https://github.com/jrbourbeau/optuna.git@dask-storage |
There was a problem hiding this comment.
| pip install git+https://github.com/jrbourbeau/optuna.git@dask-storage | |
| pip install git+https://github.com/optuna/optuna.git |
There was a problem hiding this comment.
Whoops, apologies for the delay. Just updated the link 👍
This PR adds an example for Optuna's upcoming native Dask integration (xref optuna/optuna#2023). This shouldn't be merged until after optuna/optuna#2023 has been merged