Pass two arguments to the forward of ConstrainedMCObjective to support botorch=0.10.0
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test seems fine with the oldest botorch version supported by optuna: $ pip install "botorch<=0.8.1"
...
$ pytest tests/test_botorch.py
========================================================================== test session starts ===========================================================================
platform darwin -- Python 3.10.13, pytest-8.0.1, pluggy-1.4.0
rootdir: /Users/nzw0301/Documents/oss/optuna-integration
configfile: pyproject.toml
plugins: jaxtyping-0.2.28, anyio-4.3.0, typeguard-2.13.3
collected 40 items
...
============================================================== 39 passed, 1 skipped, 132 warnings in 41.40s ============================================================== |
y0z
added
the
enhancement
|
This pull request has not seen any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #97.
Description of the changes
Revert #96 and pass two arguments to
ConstrainedMCObjective'sforwardthat should take two arguments since v0.10.0 by pytorch/botorch#2199 and older botorch supports both one and two arguments.