Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on an arbitrary branch #15

Merged
merged 12 commits into from
Apr 26, 2023

Conversation

gen740
Copy link
Collaborator

@gen740 gen740 commented Apr 18, 2023

Motivation

Optuna Integration is currently running on the Optuna release version, but proper testing cannot be conducted on the master branch due to Optuna's transitional modules not being removed.

Description of the changes

  • Add a workflow input to specify which Optuna repository should be used.
  • Fix tests.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@14cc833). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff           @@
##             main     #15   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       9           
  Lines           ?     505           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?     505           
  Partials        ?       0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gen740
Copy link
Collaborator Author

gen740 commented Apr 21, 2023

@HideakiImamura Could you review this PR, please?

@gen740
Copy link
Collaborator Author

gen740 commented Apr 21, 2023

I confirmed that workflow dispatch input works properly.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good.

@HideakiImamura HideakiImamura merged commit 905a952 into optuna:main Apr 26, 2023
16 checks passed
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone Apr 26, 2023
@HideakiImamura HideakiImamura added test Unit test. CI Continuous integration. and removed test Unit test. labels Apr 26, 2023
@gen740 gen740 changed the title Test on arbitary branch Test on an arbitrary branch May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants