Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move skorch #22

Merged
merged 13 commits into from
May 15, 2023
Merged

Move skorch #22

merged 13 commits into from
May 15, 2023

Conversation

eukaryo
Copy link
Contributor

@eukaryo eukaryo commented May 11, 2023

Motivation

Progress optuna/optuna#4484

Description of the changes

  • Move integration/skorch.py and its test from optuna/optuna.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ca3833f). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff           @@
##             main     #22   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      12           
  Lines           ?     567           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?     567           
  Partials        ?       0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HideakiImamura HideakiImamura self-assigned this May 11, 2023
@HideakiImamura
Copy link
Member

@eukaryo Please resolve conflicts.

@eukaryo
Copy link
Contributor Author

eukaryo commented May 11, 2023

@HideakiImamura I have resolved current conflict, and all checks have passed.
If other conflicts occur, I am fine with that. So you may prioritize the merging of another pull request. I will follow your decision.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 45b1631 into optuna:main May 15, 2023
15 checks passed
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone May 15, 2023
@HideakiImamura HideakiImamura added the compatibility Change that breaks compatibility. label May 18, 2023
@eukaryo eukaryo deleted the move_skorch branch April 19, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants