Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formats.sh based on optuna/master #75

Merged
merged 1 commit into from Feb 8, 2024

Conversation

nabenabe0928
Copy link
Collaborator

@nabenabe0928 nabenabe0928 commented Feb 8, 2024

Motivation

As formatting is one of the requirements of PRs to be merged, I would like to add formats.sh so that external contributors can easily verify how to fix their modifications.

Description of the changes

I added format.sh based on the optuna master branch.

The only change I made from the optuna master branch is here:

image

The corresponding lines

@nabenabe0928
Copy link
Collaborator Author

@contramundum53 Could you review this PR?

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2fd5266) 65.09% compared to head (5039344) 65.06%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   65.09%   65.06%   -0.04%     
==========================================
  Files          25       25              
  Lines        1868     1869       +1     
==========================================
  Hits         1216     1216              
- Misses        652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 merged commit 8c6eb13 into optuna:main Feb 8, 2024
10 checks passed
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 8, 2024
@nabenabe0928 nabenabe0928 added the enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Change that does not break compatibility and not affect public interfaces, but improves performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants