Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastai readme fix #82

Merged
merged 3 commits into from Feb 13, 2024
Merged

Fastai readme fix #82

merged 3 commits into from Feb 13, 2024

Conversation

DanielAvdar
Copy link
Contributor

Motivation

Description of the changes

@DanielAvdar DanielAvdar marked this pull request as ready for review February 9, 2024 10:00
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33a2d2d) 64.59% compared to head (de58335) 64.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   64.59%   64.67%   +0.08%     
==========================================
  Files          29       29              
  Lines        2409     2409              
==========================================
+ Hits         1556     1558       +2     
+ Misses        853      851       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, we can merge this PR after applying the suggestion!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, LGTM!

@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 13, 2024
@nabenabe0928 nabenabe0928 added the code-fix Change that does not change the behavior, such as code refactoring. label Feb 13, 2024
@nabenabe0928 nabenabe0928 merged commit 47cf5ae into optuna:main Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants