Fix import path #83
Merged
Fix import path #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 64.59% 64.59%
=======================================
Files 29 29
Lines 2409 2409
=======================================
Hits 1556 1556
Misses 853 853 ☔ View full report in Codecov by Sentry. |
nabenabe0928
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix CI failure in
optuna/example. See https://github.com/optuna/optuna-examples/actions/runs/7845757202Description of the changes
Fix wrong import path to
try_import(), which was brought by #65.with open optuna_integration._imports.try_import() as _imports:fails sinceoptuna_integration._importsand_importscauses name collision (cf. PEP343)See Alnusjaponica/optuna-examples#3 for the outcome.