Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of dependencies by name #92

Merged
merged 1 commit into from Feb 26, 2024

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Feb 22, 2024

Motivation

Alphabetical ordering makes the file more readable.

Description of the changes

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89b3058) 72.61% compared to head (468760c) 72.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          39       39           
  Lines        3334     3334           
=======================================
  Hits         2421     2421           
  Misses        913      913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53 contramundum53 merged commit 907a51a into optuna:main Feb 26, 2024
12 checks passed
@contramundum53 contramundum53 added this to the v3.6.0 milestone Feb 26, 2024
@contramundum53 contramundum53 added the code-fix Change that does not change the behavior, such as code refactoring. label Feb 26, 2024
@nzw0301 nzw0301 deleted the order-by-name branch February 26, 2024 06:28
@y0z y0z changed the title Change the order of dependecies by name Change the order of dependencies by name Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants