Skip to content

Commit

Permalink
Merge pull request #4023 from not522/fix-skopt-seed
Browse files Browse the repository at this point in the history
Fix duplicated sampling of `SkoptSampler`
  • Loading branch information
toshihikoyanase committed Oct 4, 2022
2 parents 2498b7c + f54e1ef commit 7da2f2d
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion optuna/integration/skopt.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def __init__(

if seed is not None and "random_state" not in self._skopt_kwargs:
self._skopt_kwargs["random_state"] = seed
self._rng: Optional[np.random.RandomState] = None

def reseed_rng(self) -> None:

Expand Down Expand Up @@ -177,8 +178,12 @@ def sample_relative(
return {}

optimizer = _Optimizer(search_space, self._skopt_kwargs)
if self._rng is not None:
optimizer._optimizer.rng = self._rng
optimizer.tell(study, complete_trials)
return optimizer.ask()
params = optimizer.ask()
self._rng = optimizer._optimizer.rng
return params

def sample_independent(
self,
Expand Down

0 comments on commit 7da2f2d

Please sign in to comment.