Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.10 #2981

Closed
hvy opened this issue Oct 5, 2021 · 9 comments · Fixed by #3353 or #3510
Closed

Support Python 3.10 #2981

hvy opened this issue Oct 5, 2021 · 9 comments · Fixed by #3353 or #3510
Labels
no-stale Exempt from stale bot other Issue/PR that does not fit into any other label. v3 Issue/PR for Optuna version 3.

Comments

@hvy
Copy link
Member

hvy commented Oct 5, 2021

Motivation

Python 3.10 has been released https://www.python.org/downloads/release/python-3100/.

Since 3.10 users can be expected, we should make sure that Optuna works with this version.

Description

Add 3.10 to the unit test and optuna-example CI matrices. Make sure that all jobs complete successfully. Note that necessary Docker images and other tools may be missing, yet.

Additional context (optional)

See also the following issues/PRs from 3.9 for reference.

@hvy hvy added the other Issue/PR that does not fit into any other label. label Oct 5, 2021
@not522 not522 added the no-stale Exempt from stale bot label Oct 5, 2021
@HideakiImamura
Copy link
Member

GitHub Actions allows to use Python 3.10. So, we would like to setup the CI.

@HideakiImamura
Copy link
Member

actions/setup-python#249

@hvy hvy pinned this issue Oct 20, 2021
@hugovk
Copy link
Contributor

hugovk commented Oct 26, 2021

Python 3.10.0 is now available: actions/setup-python#249 (comment)

@toshihikoyanase toshihikoyanase added the v3 Issue/PR for Optuna version 3. label Dec 19, 2021
@toshihikoyanase
Copy link
Member

We'd like to check this issue before releasing v3. Let me add the v3 label.

@semiexp
Copy link
Contributor

semiexp commented Dec 19, 2021

I tested the compatibility with Python 3.10 in #3179, but pip install torch failed (torch does not support 3.10 yet): https://github.com/optuna/optuna/runs/4572899427?check_suite_focus=true

@hugovk
Copy link
Contributor

hugovk commented Dec 19, 2021

Here's the torch issue: pytorch/pytorch#66424

@nzw0301
Copy link
Member

nzw0301 commented Mar 11, 2022

FYI: PyTorch 1.11.0 has been released! This version starts to support Python 3.10.

@nzw0301
Copy link
Member

nzw0301 commented Apr 4, 2022

Let me summarise the current status of this issue (at least on my local machine):

  • I locally confirmed that the test of allennlp 2.9. 2 with torch 1.11.0 was successful without any modification; I could not reproduce CI failed due to the error in AllenNLP integration #3366.
  • I locally confirmed that PyTorch Lightning 1.6.0 with torch 1.11.0 was successful if we modified the definition of pytorch-lightning callback as in this dirty PR.

Hence I think we can resolve this issue in the following steps:

  1. Merge Partially support Python 3.10 #3353
  2. Bump-up torch and related libraries except for PyTorchLightning and remove python 3.10 condition introduced by Partially support Python 3.10 #3353 (this is because PyTorch lightning's modification will not be as trivial as others.)
  3. Update PyTorchLightningCallback and unpin its version.

@nzw0301 nzw0301 reopened this Apr 22, 2022
@nzw0301 nzw0301 added the contribution-welcome Issue that welcomes contribution. label Apr 22, 2022
This was referenced Apr 24, 2022
@HideakiImamura
Copy link
Member

HideakiImamura commented May 20, 2022

We will work on PyTorchLightningCallback in the other issue, so we will remove it from the TODO of this issue.

@HideakiImamura HideakiImamura removed the contribution-welcome Issue that welcomes contribution. label May 20, 2022
@nzw0301 nzw0301 linked a pull request May 20, 2022 that will close this issue
@nzw0301 nzw0301 removed a link to a pull request May 20, 2022
@nzw0301 nzw0301 linked a pull request May 20, 2022 that will close this issue
@nzw0301 nzw0301 unpinned this issue May 22, 2022
@not522 not522 mentioned this issue Sep 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Exempt from stale bot other Issue/PR that does not fit into any other label. v3 Issue/PR for Optuna version 3.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants