Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve mypy error on master branch #4116

Closed
nzw0301 opened this issue Nov 3, 2022 · 0 comments · Fixed by #4410 or #4413
Closed

Resolve mypy error on master branch #4116

nzw0301 opened this issue Nov 3, 2022 · 0 comments · Fixed by #4410 or #4413
Labels
code-fix Change that does not change the behavior, such as code refactoring.

Comments

@nzw0301
Copy link
Member

nzw0301 commented Nov 3, 2022 •
edited

Motivation

Due to the recent release of pytorch-lightning, Checks (Integration) fails on the master branch
https://github.com/optuna/optuna/actions/runs/3381750055.

Suggestion

The changelog says

Renamed training_type_plugin file to strategy

So we can replace training_type_plugin with strategy in the integration file.

Additional context (optional)

The pytorch-lightning integration is not tested while in optuna #3418.
@nzw0301 nzw0301 added code-fix Change that does not change the behavior, such as code refactoring. contribution-welcome Issue that welcomes contribution. labels Nov 3, 2022
@higucheese higucheese mentioned this issue Nov 6, 2022
Closed
3 tasks
@hvy hvy removed the contribution-welcome Issue that welcomes contribution. label Nov 29, 2022
This was referenced Jan 5, 2023
Closed
Merged
Merged
This was referenced Feb 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Milestone
No milestone
2 participants
@hvy @nzw0301