Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer OPTUNA_STORAGE environment variable in non-CLI functions #4317

Closed
g-votte opened this issue Jan 11, 2023 · 2 comments
Closed

Refer OPTUNA_STORAGE environment variable in non-CLI functions #4317

g-votte opened this issue Jan 11, 2023 · 2 comments
Labels
feature Change that does not break compatibility, but affects the public interfaces. needs-discussion Issue/PR which needs discussion. stale Exempt from stale bot labeling.

Comments

@g-votte
Copy link
Member

g-votte commented Jan 11, 2023

Motivation

Although #4299 enabled to automatically load the environment variable of OPTUNA_STORAGE, this feature is limited to the CLI so far. This issue discusses providing the OPTUNA_STORAGE variable also with non-CLI functions.

Description

One of the simplest ways would be to add a logic to automatically load OPTUNA_STORAGE in get_storage. However, there're some pros and cons as follows. We may want to carefully discuss them before the implementation.

  • Pros
    • CLI and non-CLI features will become consistent. In general, the CLI is just a wrapper of the main Optuna module, and the CLI shouldn't contain its own features and logics. Otherwise, it'll gradually become impossible to keep the consistency.
  • Cons
    • Automatically loading OPTUNA_STORAGE may cause problems to the users, because it is rather a common variable name to make it a reserved word. Some users might already have used the name in their systems.

Alternatives (optional)

No response

Additional context (optional)

No response

@g-votte g-votte added feature Change that does not break compatibility, but affects the public interfaces. needs-discussion Issue/PR which needs discussion. labels Jan 11, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This issue was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Change that does not break compatibility, but affects the public interfaces. needs-discussion Issue/PR which needs discussion. stale Exempt from stale bot labeling.
Projects
None yet
Development

No branches or pull requests

1 participant