Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trial._study_id and use trial.study._study_id instead. #4678

Closed
c-bata opened this issue May 17, 2023 · 1 comment
Closed

Remove trial._study_id and use trial.study._study_id instead. #4678

c-bata opened this issue May 17, 2023 · 1 comment
Labels
code-fix Change that does not change the behavior, such as code refactoring. contribution-welcome Issue that welcomes contribution. good first issue Good first issue for contribution.

Comments

@c-bata
Copy link
Member

c-bata commented May 17, 2023

Motivation

As described in the following TODO comment, trial._study_id is a bit redundant since trial has study attribute.

optuna/optuna/trial/_trial.py

Lines 54 to 55 in 5f10ae4

# TODO(Yanase): Remove _study_id attribute, and use study._study_id instead.
self._study_id = self.study._study_id

Suggestion

Remove trial._study_id and use trial.study._study_id instead.

Additional context (optional)

No response
@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label May 17, 2023
@c-bata c-bata mentioned this issue May 17, 2023
Merged
1 task
@c-bata c-bata added contribution-welcome Issue that welcomes contribution. good first issue Good first issue for contribution. labels May 17, 2023
@rishabsinghh
Copy link
Contributor

Hi, i would like to start working on this issue

@adjeiv adjeiv mentioned this issue Jul 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-fix Change that does not change the behavior, such as code refactoring. contribution-welcome Issue that welcomes contribution. good first issue Good first issue for contribution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@c-bata @rishabsinghh @Alnusjaponica