Remove _study_id parameter from Trial class #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
optuna.trial
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4811 +/- ##
==========================================
+ Coverage 90.67% 90.69% +0.01%
==========================================
Files 195 195
Lines 14602 14601 -1
==========================================
+ Hits 13241 13242 +1
+ Misses 1361 1359 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for the PR. I believe the CI error is not caused by the changes in this PR, so let me rerun it. |
HideakiImamura
added
the
code-fix
|
@Alnusjaponica Could you review this PR? |
Alnusjaponica
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Referencing issue #4678
All uses of
trial._study_idwere removed in optuna/optuna-dashboard/pull/463, which was merged into the main optuna repository.Description of the changes
Remove the
_study_idparameter from the Trial class, and remove the test that checks the_study_idparameter was always the same asstudy._study_id.