Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the behavior of the terminator and its visualization function #5073

Open
HideakiImamura opened this issue Oct 25, 2023 · 0 comments
Open
Labels
contribution-welcome Issue that welcomes contribution. feature Change that does not break compatibility, but affects the public interfaces.

Comments

@HideakiImamura
Copy link
Member

Motivation

We are developing optuna.terminator as an automatic termination module, and have prepared optuna.visualization.plot_terminator_improvement for its visualization. However, there are inconsistencies in their behavior, and I propose that we align them.

Description

The optuna.terminator.Terminator class is initialized with improvement_evaluator, error_evaluator, and min_n_trials. If improvement_evaluator is an instance of BestValueStagnationEvaluator and error_evaluator is None, error_evaluator is initialized with StaticErrorEvaluator(constant=0) (ref). plot_terminator_improvement is not set up like this. The latter should be made to match the former.

Alternatives (optional)

No response

Additional context (optional)

No response

@HideakiImamura HideakiImamura added feature Change that does not break compatibility, but affects the public interfaces. contribution-welcome Issue that welcomes contribution. labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution-welcome Issue that welcomes contribution. feature Change that does not break compatibility, but affects the public interfaces.
Projects
None yet
Development

No branches or pull requests

1 participant