Fix inconsistencies between terminator and terminator visualization i… #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5276 +/- ##
==========================================
+ Coverage 89.57% 89.58% +0.01%
==========================================
Files 209 209
Lines 13097 13101 +4
==========================================
+ Hits 11732 11737 +5
+ Misses 1365 1364 -1 ☔ View full report in Codecov by Sentry. |
|
@contramundum53 Could you review this PR? |
|
Thank you for your contribution! |
|
@HideakiImamura Could you review this PR as the author of the issue? |
HideakiImamura
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The goal of this pull request is to answer issue #5073
Motivation
As mentioned in the issue, the objective is to harmonize the
plot_terminator_improvementfunction andTerminatorclass when initializing theerror_evaluatorobject.Description of the changes
It adds a similar logic to the initialization of the
error_evaluatorforplot_terminator_improvementso that it reflects what theTerminatorclass does.Suggestions
Currently, I replicated the logic in
plot_terminator_improvement. Should I factorize that code with that of theTerminatorclass so that when updated, we do not risk creating the same discrepancy in the future?I could add a static method to Terminator to initialize
error_evaluator. What do you think? That way, I could also add a unit test more easily.