suggest_float with step in multi_objective #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himkt
reviewed
May 4, 2020
optuna/multi_objective/trial.py
Outdated
| @@ -42,14 +42,16 @@ def __init__(self, trial: Trial): | |||
| # See also: https://github.com/optuna/optuna/pull/1054/files#r407982636 | |||
| self._n_objectives = multi_objective.study.MultiObjectiveStudy(trial.study).n_objectives | |||
|
|
|||
| def suggest_float(self, name: str, low: float, high: float, *, log: bool = False) -> float: | |||
| def suggest_float( | |||
| self, name: str, low: float, high: float, *, log: bool = False, step: Optional[float] = None | |||
There was a problem hiding this comment.
Please apply black by black --line-length 99 optuna/multi_objective/trial.py.
https://circleci.com/gh/optuna/optuna/39429
himkt
approved these changes
May 4, 2020
sile
added
the
feature
|
Thank you for reviewing my PR! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
suggest_floatcan takestepargument but it cannot be available inmulti_objective.Description of the changes
Add
stepargumentsuggest_floatand its tests commented by @himkt in #1203 (comment).It also contains minor fix in the test file.