Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move colorlog after threading. #1211

Merged
merged 1 commit into from
May 7, 2020
Merged

Move colorlog after threading. #1211

merged 1 commit into from
May 7, 2020

Conversation

himkt
Copy link
Member

@himkt himkt commented May 6, 2020

Related to #514.

Motivation

This is a tweak PR but colorlog is not a standard library.
(ref. https://pypi.org/project/colorlog/)

Description of the changes

  • edited logging.py to import colorlog after importing standard libraries

toshihikoyanase
toshihikoyanase approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@toshihikoyanase toshihikoyanase self-assigned this May 7, 2020
@toshihikoyanase toshihikoyanase added the code-fix Change that does not change the behavior, such as code refactoring. label May 7, 2020
@toshihikoyanase toshihikoyanase added this to the v1.4.0 milestone May 7, 2020
@toshihikoyanase toshihikoyanase merged commit f3bf535 into optuna:master May 7, 2020
@himkt himkt deleted the pep-import branch May 7, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshihikoyanase toshihikoyanase toshihikoyanase approved these changes

Assignees

@toshihikoyanase toshihikoyanase

Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himkt @toshihikoyanase