Add a caching mechanism to make NSGAIIMultiObjectiveSampler faster.
#1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sile
added
the
enhancement
sile
changed the title
NSGAIIMultiObjectiveSampler faster.NSGAIIMultiObjectiveSampler faster.
Codecov Report
@@ Coverage Diff @@
## master #1257 +/- ##
==========================================
+ Coverage 88.00% 88.16% +0.16%
==========================================
Files 97 98 +1
Lines 7301 7410 +109
==========================================
+ Hits 6425 6533 +108
- Misses 876 877 +1
Continue to review full report at Codecov.
|
Benchmark ResultElapsed time
Optimization Performance
The results are exactly the same before and after applying this PR. Commands$ pip3 install --user git+https://github.com/optuna/optuna@9b3eccfc1a
$ kurobako solver --name 'NSGA-II@master' command python3 nsga2.py > solver-master.json
$ kurobako studies --problems $(kurobako problem zdt 1) --solvers $(cat solver-master.json) --repeats 1 --budget 1000 --seed 0 | kurobako run > result-master.json
$ pip3 install --user git+https://github.com/sile/optuna@aa8b578
$ kurobako solver --name 'NSGA-II@pr1257' command python3 nsga2.py > solver-pr1257.json
$ kurobako studies --problems $(kurobako problem zdt 1) --solvers $(cat solver-pr1257.json) --repeats 1 --budget 1000 --seed 0 | kurobako run > result-pr1257.json
$ cat result-*.json | kurobako plot curve --metric solver-elapsed-time
$ cat result-*.json | kurobako plot pareto-front --ymin 1 --ymax 7 |
sile
changed the title
NSGAIIMultiObjectiveSampler faster.NSGAIIMultiObjectiveSampler faster.
|
This pull request has not seen any recent activity. |
ytsmiling
reviewed
Jun 24, 2020
Co-authored-by: Yusuke Tsuzuku <ytsmiling@users.noreply.github.com>
|
Fixed the CI failure. PTAL 🙇 > @ytsmiling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
NSGAIIMultiObjectiveSampleris unnecessarily slow because it calculates the latest population from scratch each time when therelative_samplemethod is called.This PR makes it faster by storing caches of populations to the study system attributes and eliminating the need of the redundant recalculation.
TODO