Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to utils.py. #1270

Merged
merged 4 commits into from May 29, 2020
Merged

Conversation

bigbird555
Copy link
Contributor

Motivation

Please refer to #711 .

Description of the changes

I added some type hints to optuna/visualization/utils.py

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #1270 into master will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   87.01%   86.73%   -0.29%     
==========================================
  Files          94       95       +1     
  Lines        7233     7432     +199     
==========================================
+ Hits         6294     6446     +152     
- Misses        939      986      +47     
Impacted Files Coverage Δ
optuna/visualization/utils.py 87.50% <100.00%> (+9.72%) ⬆️
optuna/cli.py 27.27% <0.00%> (-4.78%) ⬇️
optuna/samplers/cmaes.py 77.16% <0.00%> (-2.57%) ⬇️
optuna/samplers/tpe/sampler.py 86.22% <0.00%> (-2.00%) ⬇️
optuna/importance/_fanova.py 86.30% <0.00%> (-0.85%) ⬇️
optuna/storages/rdb/storage.py 95.16% <0.00%> (-0.67%) ⬇️
optuna/integration/chainermn.py 75.41% <0.00%> (-0.29%) ⬇️
optuna/storages/cached_storage.py 95.63% <0.00%> (-0.20%) ⬇️
optuna/exceptions.py 100.00% <0.00%> (ø)
optuna/pruners/nop.py 75.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95aac0...b55b06c. Read the comment docs.

@keisuke-umezawa keisuke-umezawa requested review from keisuke-umezawa and removed request for keisuke-umezawa May 25, 2020 02:52
@keisuke-umezawa keisuke-umezawa self-assigned this May 25, 2020
Copy link
Member

@keisuke-umezawa keisuke-umezawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keisuke-umezawa keisuke-umezawa merged commit 00b6a19 into optuna:master May 29, 2020
@keisuke-umezawa keisuke-umezawa added the code-fix Change that does not change the behavior, such as code refactoring. label May 29, 2020
@keisuke-umezawa keisuke-umezawa added this to the v2.0.0 milestone May 29, 2020
@keisuke-umezawa keisuke-umezawa added the optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. label May 29, 2020
@bigbird555 bigbird555 deleted the fix-utils branch May 31, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants