Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to test_chainer.py. #1286

Merged
merged 1 commit into from Jun 2, 2020

Conversation

bigbird555
Copy link
Contributor

Motivation

Please refer to the Issue #711 .

Description of the changes

I added type hints to integration_tests/test_chainer.py.

@codecov-commenter
Copy link

Codecov Report

Merging #1286 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1286   +/-   ##
=======================================
  Coverage   86.70%   86.71%           
=======================================
  Files          95       95           
  Lines        7434     7437    +3     
=======================================
+ Hits         6446     6449    +3     
  Misses        988      988           
Impacted Files Coverage Δ
optuna/integration/allennlp.py 86.66% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48e462...3cae230. Read the comment docs.

@keisuke-umezawa keisuke-umezawa self-assigned this May 29, 2020
@keisuke-umezawa keisuke-umezawa added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 2, 2020
@keisuke-umezawa keisuke-umezawa added this to the v2.0.0 milestone Jun 2, 2020
@keisuke-umezawa keisuke-umezawa merged commit 89b6169 into optuna:master Jun 2, 2020
@bigbird555 bigbird555 deleted the fix-test-chainer branch June 3, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants