Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of projects using Optuna to examples/README.md #1605

Merged
merged 7 commits into from
Sep 1, 2020

Conversation

Crissman
Copy link
Contributor

@Crissman Crissman commented Aug 7, 2020

Motivation

Work with other projects that are using Optuna.

Description of the changes

Add a section to the examples/README.md which lists other projects that are using Optuna.

WIP while reaching out to the partners to ensure they're ok with being listed, and look for more.

@Crissman
Copy link
Contributor Author

Crissman commented Aug 7, 2020

@araffin Can you let me know if including the RL Zoo and the link is ok with you?

@cthoyt
Copy link

cthoyt commented Aug 7, 2020

Excellent, @Crissman. Thanks for including PyKEEN.

@araffin
Copy link
Contributor

araffin commented Aug 7, 2020

@araffin Can you let me know if including the RL Zoo and the link is ok with you?

Please do, maybe include the v3 too?
the v2 is already on maintenance mode
https://github.com/DLR-RM/rl-baselines3-zoo

@Crissman Crissman marked this pull request as ready for review August 26, 2020 02:58
@Crissman Crissman changed the title WIP Add list of projects using Optuna to README.md Add list of projects using Optuna to README.md Aug 26, 2020
@Crissman Crissman changed the title Add list of projects using Optuna to README.md Add list of projects using Optuna to examples/README.md Aug 26, 2020
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Could you merge upstream/master to resolve the CI failure? And also, I added a suggestion.

examples/README.md Show resolved Hide resolved
@toshihikoyanase toshihikoyanase self-assigned this Aug 26, 2020
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your update. LGTM.

@toshihikoyanase toshihikoyanase added the document Documentation related. label Aug 28, 2020
@cthoyt
Copy link

cthoyt commented Aug 28, 2020

Before merging this PR, I would suggest putting a note welcoming authors of packages to submit additional PRs against the readme to add a link to their repositories/projects to the list.

Copy link
Member

@keisuke-umezawa keisuke-umezawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I checked that every library uses optuna.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HideakiImamura HideakiImamura merged commit 007336b into optuna:master Sep 1, 2020
@HideakiImamura HideakiImamura added this to the v2.1.0 milestone Sep 1, 2020
@HideakiImamura HideakiImamura self-assigned this Sep 1, 2020
@Crissman Crissman deleted the affiliates branch February 1, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants