Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid the latest stable sphinx #1613

Merged
merged 1 commit into from Aug 11, 2020
Merged

avoid the latest stable sphinx #1613

merged 1 commit into from Aug 11, 2020

Conversation

crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Aug 11, 2020

Motivation

Description of the changes

@crcrpar
Copy link
Contributor Author

crcrpar commented Aug 11, 2020

Let's see this avoids the https://app.circleci.com/pipelines/github/optuna/optuna/1923/workflows/b426dce6-267c-4e18-9017-35912e94279b/jobs/5162 as expected.

@crcrpar crcrpar added the document Documentation related. label Aug 11, 2020
himkt
himkt approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@himkt himkt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix. LGTM.
I'm also wondering if it's good to specify the version of the sphinx (e.g. 3.0.4) after solving the root cause.
(It's just an idea.)

ref. #1368

@crcrpar crcrpar mentioned this pull request Aug 11, 2020
Closed
toshihikoyanase
toshihikoyanase approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your quick fix.

@crcrpar
Copy link
Contributor Author

crcrpar commented Aug 11, 2020

@himkt That completely makes sense. I filed an issue on this #1614.

@toshihikoyanase toshihikoyanase merged commit 77c5b63 into optuna:master Aug 11, 2020
@HideakiImamura HideakiImamura added this to the v2.1.0 milestone Aug 11, 2020
@crcrpar crcrpar deleted the avoid-sphinx-320 branch August 11, 2020 01:06
@HideakiImamura HideakiImamura mentioned this pull request Aug 11, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshihikoyanase toshihikoyanase toshihikoyanase approved these changes

@himkt himkt himkt approved these changes

Assignees
No one assigned
Labels
document Documentation related.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crcrpar @toshihikoyanase @himkt @HideakiImamura