Stabilize create_trial
#3196
Merged
Stabilize create_trial
#3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
optuna.trial
himkt
commented
Dec 20, 2021
| @@ -183,7 +183,7 @@ def _create_trial(mo_trial: "multi_objective.trial.FrozenMultiObjectiveTrial") - | |||
| warnings.simplefilter("ignore", ExperimentalWarning) | |||
| trial = create_trial( | |||
| state=mo_trial.state, | |||
| values=mo_trial.values, | |||
| values=mo_trial.values, # type: ignore | |||
There was a problem hiding this comment.
FrozenMultiObjectiveTrial.values is not Optional[Sequence[float]]. I simply ignore this mismatch because optuna.multi_objective is entirely deprecated.
optuna/optuna/multi_objective/trial.py
Line 279 in c4791fc
Codecov Report
@@ Coverage Diff @@
## master #3196 +/- ##
==========================================
- Coverage 91.22% 91.22% -0.01%
==========================================
Files 146 146
Lines 11916 11914 -2
==========================================
- Hits 10870 10868 -2
Misses 1046 1046
Continue to review full report at Codecov.
|
HideakiImamura
added
code-fix
|
Let me merge this PR with my one approval since this is a light PR. |
himkt
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敆 #2956
We now stabilize
create_trial.