Fix parallel coordinate with missing value #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzw0301
added
bug
nzw0301
force-pushed
the
fix-parallel-coordinate-with-missing-value
branch
from
3c4251c
to
6b5268e
Compare
himkt
reviewed
Mar 16, 2022
| @@ -31,21 +31,21 @@ def test_plot_parallel_coordinate() -> None: | |||
| figure = plot_parallel_coordinate(study) | |||
| assert len(figure.data[0]["dimensions"]) == 3 | |||
| assert figure.data[0]["dimensions"][0]["label"] == "Objective Value" | |||
| assert figure.data[0]["dimensions"][0]["range"] == (0.0, 2.0) | |||
| assert figure.data[0]["dimensions"][0]["values"] == (0.0, 2.0, 1.0) | |||
| assert figure.data[0]["dimensions"][0]["range"] == (0.0, 1.0) | |||
There was a problem hiding this comment.
study.trials_dataframe()
number value datetime_start datetime_complete duration params_param_a params_param_b state
0 0 0.0 2022-03-16 09:52:21.366738 2022-03-16 09:52:21.366738 0 days 1.0 2.0 COMPLETE
1 1 2.0 2022-03-16 09:52:21.366833 2022-03-16 09:52:21.366833 0 days NaN 0.0 COMPLETE
2 2 1.0 2022-03-16 09:52:21.366892 2022-03-16 09:52:21.366892 0 days 2.5 1.0 COMPLETE
[note] study generated by testing utility has a trial with missing param, which arises a need to change existing tests.
himkt
approved these changes
Mar 16, 2022
|
I think it is already documented (but didn't work as expected). |
|
hi @HideakiImamura, I believe that your comment is answered by #3373 (comment). |
HideakiImamura
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #3372
Description of the changes
If a trial has a missing parameter used in a parallel coordinate plot, remove the trail from the visualization data for Plotly.
Note that by this change, coordinates' max/min values might change because the master's implementation set max/min based on all complete trials' values. On the other hand, this PR set max/min value based on only used trials that have no missing params. Personally, this PR's change makes sense since the parallel coordinate plot creates empty space in the coordinate as in the matplotlib's plot on #3372: 1--2 on
Objective Valueaxis or 0--1 onparam_baxis.Implementing the same logic to determine the max/min range in matplotlib should be a follow-up.