Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the version constraint of fakeredis #3561

Merged
merged 2 commits into from May 19, 2022
Merged

Remove the version constraint of fakeredis #3561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2754d26
Remove the version constraint of fakeredis
nzw0301 May 14, 2022
149fcaf
Add python version condition for fakeredis
nzw0301 May 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions setup.py
View file
Open in desktop
Expand Up @@ -94,8 +94,8 @@ def get_extras_require() -> Dict[str, List[str]]:
"testing": [
"chainer>=5.0.0",
"cma",
# TODO(HideakiImamura): Remove the version constraint after the next release.
"fakeredis<=1.7.1",
"fakeredis<=1.7.1; python_version<'3.8'",
"fakeredis ; python_version>='3.8'",
toshihikoyanase marked this conversation as resolved.
Show resolved Hide resolved
"lightgbm",
"matplotlib>=3.0.0",
"mlflow",
Expand Down Expand Up @@ -128,8 +128,8 @@ def get_extras_require() -> Dict[str, List[str]]:
"fastai ; python_version>'3.6' and python_version<'3.10'",
],
"tests": [
# TODO(HideakiImamura): Remove the version constraint after the next release.
"fakeredis<=1.7.1",
"fakeredis<=1.7.1; python_version<'3.8'",
"fakeredis ; python_version>='3.8'",
"pytest",
],
"optional": [
Expand Down