Extract mpi tests from integration CI as independent CI #3606
Conversation
|
|
||
| pip install --progress-bar off .[test] | ||
| pip install --progress-bar off .[optional] | ||
| pip install --progress-bar off .[integration] --extra-index-url https://download.pytorch.org/whl/cpu |
There was a problem hiding this comment.
My concern is that this line installs unnecessary other integration packages.
There was a problem hiding this comment.
I think it is acceptable for this PR. I guess @himkt is interested in re-organization of setup.py and we can discuss this topic there.
Codecov Report
@@ Coverage Diff @@
## master #3606 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 161 161
Lines 12392 12392
=======================================
Hits 11256 11256
Misses 1136 1136 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
|
||
| pip install --progress-bar off .[test] | ||
| pip install --progress-bar off .[optional] | ||
| pip install --progress-bar off .[integration] --extra-index-url https://download.pytorch.org/whl/cpu |
There was a problem hiding this comment.
I think it is acceptable for this PR. I guess @himkt is interested in re-organization of setup.py and we can discuss this topic there.
|
@HideakiImamura Could you review this PR as an author of #3570, please? |
|
By the way, do we update the branch protection rule to make |
Agree. May I update it required? |
Motivation
Resolve #3570
Description of the changes
Extract MPI's pytest from
.github/workflows/tests-integration.ymland create a new yaml file for MPI test.