Revert most of changes by 3651 #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzw0301
added
code-fix
|
@contramundum53 @xadrianzetx Could you review this PR since you were reviewers of #3651? |
xadrianzetx
reviewed
Aug 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #3848 +/- ##
==========================================
- Coverage 90.50% 90.49% -0.01%
==========================================
Files 164 164
Lines 12628 12617 -11
==========================================
- Hits 11429 11418 -11
Misses 1199 1199
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #3712 because the introduced changes by #3651 are unnecessary anymore, thanks to the latest stable mlflow (concretely, mlflow/mlflow#6052).
Description of the changes
Revert the changes by #3651 except for https://github.com/optuna/optuna/pull/3651/files#diff-88ddb9fb7f05a37d5fc720d442a748b3189ebf4f43500e9709fd6507803c2e30R168, which was a sort of code-fix.