Remove abstractmethod decorator from get_trial_id_from_study_id_trial_number

[c-bata]

Motivation

Revert changes in #3870.

Description of the changes

@knshnb told me that get_trial_id_from_study_id_trial_number is actually not an abstractmethod though it raises NotImplementedError. When NotImplementedError is raised, following lines handles an exception and returns trial_id.

optuna/optuna/study/_tell.py

Lines 122 to 142 in 5a1bb75

	try:
	trial_id = study._storage.get_trial_id_from_study_id_trial_number(
	study._study_id, trial_number
	)
	except NotImplementedError as e:
	warnings.warn(
	"Study.tell may be slow because the trial was represented by its number but "
	f"the storage {study._storage.__class__.__name__} does not implement the "
	"method required to map numbers back. Please provide the trial object "
	"to avoid performance degradation."
	)
	trials = study.get_trials(deepcopy=False)
	if len(trials) <= trial_number:
	raise ValueError(
	f"Cannot tell for trial with number {trial_number} since it has not been "
	"created."
	) from e
	trial_id = trials[trial_number]._trial_id

I think we should implement the default logic in BaseSampler. However, this PR revert #3870 for now, since we plan to release v3.0 next week.

[knshnb]

LGTM!

[codecov-commenter]

Codecov Report

Merging #3909 (457e9f8) into master (5a1bb75) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3909      +/-   ##
==========================================
- Coverage   90.58%   90.57%   -0.02%     
==========================================
  Files         164      164              
  Lines       12601    12600       -1     
==========================================
- Hits        11415    11412       -3     
- Misses       1186     1188       +2     

Impacted Files	Coverage Δ
optuna/storages/_base.py	71.55% <ø> (-0.26%)	⬇️
optuna/integration/botorch.py	97.37% <0.00%> (-0.88%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more