-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GPyTorch version constraint #3986
Remove GPyTorch version constraint #3986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
- Coverage 90.60% 90.58% -0.02%
==========================================
Files 167 167
Lines 13111 13111
==========================================
- Hits 11879 11877 -2
- Misses 1232 1234 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2e171da
to
be8f229
Compare
@toshihikoyanase @not522 Could you check this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I checked gpytorch 1.9.0 was installed for python 3.8, 3.9, and 3.10. For 3.7, gpytorch 1.8.1 was installed.
This pull request has not seen any recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed response. I confirmed that botorch could be installed with the following version of gpytorch:
Python | botorch | gpytorch |
---|---|---|
3.7 | 0.6.6 | 1.8.1 |
3.8 | 0.7.1 | 1.9.0 |
3.9 | 0.7.1 | 1.9.0 |
3.10 | 0.7.1 | 1.9.0 |
LGTM!
Motivation
Relax the version constraint by #3950 for GPyTorch.
BoTorch 0.7.0 was released last week. It starts to support GPyTorch>=1.9.0. however, it also drops Python 3.7 support because GPyTorch 1.9.0 drops Python 3.7. See also the release note of BoTorch. So we can remove the version constraint of GPyTorch, which is not necessary anymore.
Description of the changes
Remove the version constraint of GPyTorch by #3950.