Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPyTorch version constraint #3986

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Sep 10, 2022

Motivation

Relax the version constraint by #3950 for GPyTorch.

BoTorch 0.7.0 was released last week. It starts to support GPyTorch>=1.9.0. however, it also drops Python 3.7 support because GPyTorch 1.9.0 drops Python 3.7. See also the release note of BoTorch. So we can remove the version constraint of GPyTorch, which is not necessary anymore.

Description of the changes

Remove the version constraint of GPyTorch by #3950.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #3986 (be8f229) into master (79f0329) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3986      +/-   ##
==========================================
- Coverage   90.60%   90.58%   -0.02%     
==========================================
  Files         167      167              
  Lines       13111    13111              
==========================================
- Hits        11879    11877       -2     
- Misses       1232     1234       +2     
Impacted Files Coverage Δ
optuna/integration/botorch.py 97.37% <0.00%> (-0.88%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nzw0301 nzw0301 marked this pull request as draft September 12, 2022 02:58
@nzw0301 nzw0301 marked this pull request as ready for review September 12, 2022 03:37
@nzw0301 nzw0301 changed the title Relax GPyTorch version constraint Remove GPyTorch version constraint Sep 12, 2022
@nzw0301 nzw0301 added CI Continuous integration. installation Installation and dependency. labels Sep 12, 2022
@contramundum53
Copy link
Member

@toshihikoyanase @not522 Could you check this PR?

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked gpytorch 1.9.0 was installed for python 3.8, 3.9, and 3.10. For 3.7, gpytorch 1.8.1 was installed.

@not522 not522 removed their assignment Sep 13, 2022
@github-actions
Copy link
Contributor

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Sep 20, 2022
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response. I confirmed that botorch could be installed with the following version of gpytorch:

Python botorch gpytorch
3.7 0.6.6 1.8.1
3.8 0.7.1 1.9.0
3.9 0.7.1 1.9.0
3.10 0.7.1 1.9.0

LGTM!

@toshihikoyanase toshihikoyanase added this to the v3.1.0 milestone Sep 26, 2022
@toshihikoyanase toshihikoyanase merged commit 58434f9 into optuna:master Sep 26, 2022
@nzw0301 nzw0301 deleted the relax-constraint-gpytorch branch September 26, 2022 06:01
@contramundum53 contramundum53 removed the CI Continuous integration. label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation and dependency. stale Exempt from stale bot labeling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants