Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log_loss instead of deprecated log since sklearn 1.1 #3993

Merged

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Sep 12, 2022

Motivation

The loss argument of skelarn's SGDClassifier reads

Deprecated since version 1.1: The loss ‘log’ was deprecated in v1.1 and will be removed in version 1.3. Use loss='log_loss' which is equivalent.

By this deprecation, the output of a tutorial looks a little bit messy as follows:

Screenshot 2022-09-12 at 21 41 20

Description of the changes

By following sklearn, replace "log" with "log_loss" in the code of the tutorial.

@nzw0301 nzw0301 added the document Documentation related. label Sep 12, 2022
Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@contramundum53 contramundum53 added this to the v3.1.0 milestone Sep 12, 2022
@contramundum53 contramundum53 merged commit 09e3dd9 into optuna:master Sep 12, 2022
@nzw0301 nzw0301 deleted the resolve-deprecated-message-from-sklearn branch September 13, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants