Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteCatalyst integration for migration to optuna-integration #4644

Merged
merged 2 commits into from
May 10, 2023

Conversation

Alnusjaponica
Copy link
Collaborator

Motivation

Progress #4484

Description of the changes

Delete Catalyst related implementation and tests.

Note that there are no example code for catalyst in optuna/optuna-example and this PR can be merged without changing its CI.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Apr 28, 2023
@Alnusjaponica Alnusjaponica marked this pull request as ready for review April 28, 2023 11:59
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label May 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4644 (5fa1b5f) into master (76532ac) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #4644      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.02%     
==========================================
  Files         184      184              
  Lines       13960    13949      -11     
==========================================
- Hits        12688    12676      -12     
- Misses       1272     1273       +1     
Impacted Files Coverage Δ
optuna/integration/catalyst.py 0.00% <0.00%> (-84.62%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label May 9, 2023
@HideakiImamura HideakiImamura self-assigned this May 10, 2023
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura removed their assignment May 10, 2023
Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 added this to the v3.2.0 milestone May 10, 2023
@contramundum53 contramundum53 merged commit e0caeb0 into optuna:master May 10, 2023
40 checks passed
@Alnusjaponica Alnusjaponica deleted the remove-catalyst branch May 10, 2023 01:48
@toshihikoyanase toshihikoyanase added the compatibility Change that breaks compatibility. label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants