Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs #4732

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix docs #4732

merged 1 commit into from
Jun 9, 2023

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Jun 7, 2023

Motivation

Improve docs.

Description of the changes

@nzw0301 nzw0301 added the document Documentation related. label Jun 7, 2023
@github-actions github-actions bot added optuna.samplers Related to the `optuna.samplers` submodule. This is automatically labeled by github-actions. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. labels Jun 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4732 (1616365) into master (a031e95) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #4732   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         188      188           
  Lines       14323    14323           
=======================================
  Hits        13014    13014           
  Misses       1309     1309
Impacted Files Coverage Δ
optuna/samplers/_nsgaiii.py 97.41% <ø> (ø)
optuna/terminator/callback.py 100.00% <ø> (ø)
optuna/terminator/erroreval.py 97.67% <ø> (ø)
optuna/terminator/terminator.py 96.66% <ø> (ø)
optuna/visualization/_terminator_improvement.py 98.79% <ø> (ø)
...isualization/matplotlib/_terminator_improvement.py 48.78% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Alnusjaponica
Alnusjaponica approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the follow-up!

contramundum53
contramundum53 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

@contramundum53 contramundum53 merged commit 548601e into optuna:master Jun 9, 2023
34 checks passed
@nzw0301 nzw0301 deleted the improve-docs-introduced-3.2 branch June 9, 2023 09:00
@nzw0301 nzw0301 added this to the v3.3.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contramundum53 contramundum53 contramundum53 approved these changes

@Alnusjaponica Alnusjaponica Alnusjaponica approved these changes

Assignees
No one assigned
Labels
document Documentation related. optuna.samplers Related to the `optuna.samplers` submodule. This is automatically labeled by github-actions. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nzw0301 @codecov-commenter @contramundum53 @Alnusjaponica