-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort params on fetch #4775
Sort params on fetch #4775
Conversation
@gen740 Could you review this PR? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4775 +/- ##
==========================================
- Coverage 90.75% 90.73% -0.02%
==========================================
Files 190 190
Lines 14468 14470 +2
==========================================
Hits 13130 13130
- Misses 1338 1340 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
On
RDBStorage
, param order is not conserved in user API, although the database stores the order information in the form ofparam_id
. This creates issues (e.g. #4771) for certain samplers that use the order of parameters to analyze the parameter dependency relation in dynamic search space. We ensure thatRDBStorage
returns the parameters in the order they are suggested.Description of the changes
trial.params
is in the order they are suggested, inRDBStorage
.trial.params
are in the right order.