Fix Pytorch lightning unit test #4780
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4780 +/- ##
=======================================
Coverage 90.74% 90.75%
=======================================
Files 190 190
Lines 14444 14444
=======================================
+ Hits 13107 13108 +1
+ Misses 1337 1336 -1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@not522 Could you review this PR if you have time? |
| from typing import Union | ||
| from __future__ import annotations | ||
|
|
||
| from collections.abc import Sequence |
There was a problem hiding this comment.
I guess you unintentionally changed the import statement here.
| from collections.abc import Sequence | |
| from typing import Sequence |
There was a problem hiding this comment.
I believe it is recommended by PEP584.
If it is better to separate type annotation update from this PR I'll revert the change.
There was a problem hiding this comment.
Thank you for letting me know! I didn't know that 🙇
Motivation
Resolve #4524
Description of the changes
See #4524