Loose coupling nsgaii elite population selection #4821
Conversation
github-actions
bot
added
the
optuna.samplers
Alnusjaponica
force-pushed
the
loose-coupling-NSGAII-elite-population-selection
branch
from
8fb39b3
to
d511a75
Compare
Alnusjaponica
changed the title
|
@HideakiImamura Could you review this PR, please? |
There was a problem hiding this comment.
Just for confirmation. The loose coupling of the elite population selection for the NSGAIIISampler will be done as a follow-up?
There was a problem hiding this comment.
Yes, I am going to do it as a follow-up.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4821 +/- ##
==========================================
+ Coverage 89.53% 89.55% +0.01%
==========================================
Files 197 198 +1
Lines 14671 14689 +18
==========================================
+ Hits 13135 13154 +19
+ Misses 1536 1535 -1
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
optuna/samplers/nsgaii/_sampler.py
Outdated
| .. note:: | ||
|
|
||
| The arguments ``elite_population_selection_strategy``, | ||
| ``child_generation_strategy``, and ``after_trial_strategy`` was added in v3.3.0 as | ||
| an experimental feature. The interface may change in newer versions without prior | ||
| notice. See https://github.com/optuna/optuna/releases/tag/v3.3.0. |
There was a problem hiding this comment.
It seems the note has been added to only one argument, specifically after_trial_strategy, and not to all three. While it might seem redundant, would it be worth considering adding similar notes to elite_population_selection_strategy and child_generation_strategy as well?
HideakiImamura
added
the
code-fix
Alnusjaponica
deleted the
loose-coupling-NSGAII-elite-population-selection
branch
Motivation
Progress v3.3 task to make
NSGAII Samplerloose coupled.Description of the changes
Add
_elite_population_selection_strategyargument to the constructor ifNSGAIISamplerand separate the elite population selection process so that users can customize surviving process.Please merge this PR after #4806 is merged.