Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrderedDict #4838

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Remove OrderedDict #4838

merged 1 commit into from
Jul 28, 2023

Conversation

taniokay
Copy link
Contributor

Motivation

Resolve #4592

Description of the changes

  • Replace existing OrderedDict with dict
  • Fix related tests and docstrings.

@github-actions github-actions bot added optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. optuna.samplers Related to the `optuna.samplers` submodule. This is automatically labeled by github-actions. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. optuna.importance Related to the `optuna.importance` submodule. This is automatically labeled by github-actions. labels Jul 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4838 (a65916e) into master (222194a) will increase coverage by 0.01%.
Report is 59 commits behind head on master.
The diff coverage is 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4838      +/-   ##
==========================================
+ Coverage   89.52%   89.54%   +0.01%     
==========================================
  Files         195      197       +2     
  Lines       14667    14668       +1     
==========================================
+ Hits        13131    13134       +3     
+ Misses       1536     1534       -2     
Files Changed Coverage Δ
optuna/samplers/_search_space/intersection.py 90.69% <0.00%> (-0.22%) ⬇️
optuna/importance/__init__.py 96.15% <100.00%> (-0.15%) ⬇️
optuna/importance/_base.py 94.11% <100.00%> (-0.09%) ⬇️
optuna/importance/_fanova/_evaluator.py 100.00% <100.00%> (ø)
optuna/importance/_mean_decrease_impurity.py 100.00% <100.00%> (ø)
optuna/integration/botorch.py 94.42% <100.00%> (-0.02%) ⬇️
optuna/integration/shap.py 100.00% <100.00%> (ø)
optuna/samplers/_grid.py 100.00% <100.00%> (ø)
optuna/search_space/intersection.py 100.00% <100.00%> (ø)
optuna/study/_dataframe.py 94.20% <100.00%> (ø)
... and 1 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@taniokay taniokay marked this pull request as ready for review July 26, 2023 06:54
@toshihikoyanase
Copy link
Member

@Alnusjaponica @not522 Could you review this PR, please?

@toshihikoyanase toshihikoyanase added the code-fix Change that does not change the behavior, such as code refactoring. label Jul 27, 2023
Copy link
Collaborator

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@Alnusjaponica Alnusjaponica removed their assignment Jul 27, 2023
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@not522 not522 merged commit 8811fc9 into optuna:master Jul 28, 2023
33 checks passed
@not522 not522 changed the title Remove OrderedDict Remove OrderedDict Jul 28, 2023
@not522 not522 added this to the v3.3.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring. optuna.importance Related to the `optuna.importance` submodule. This is automatically labeled by github-actions. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. optuna.samplers Related to the `optuna.samplers` submodule. This is automatically labeled by github-actions. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OrderedDict after Python 3.7
5 participants