Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alias handler #4887

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Fix alias handler #4887

merged 6 commits into from
Sep 14, 2023
+38 −14

Conversation

Alnusjaponica
Copy link
Collaborator

Motivation

Currently, _handling_alias_metrics() does nothing when pram["metric"] is a list, even though its last element is actually used as the objective for optimization. This PR resolve this problem.

Description of the changes

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited

Codecov Report

Merging #4887 (a3446cc) into master (2470936) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
- Coverage   89.47%   89.46%   -0.01%     
==========================================
  Files         200      200              
  Lines       14723    14726       +3     
==========================================
+ Hits        13173    13175       +2     
- Misses       1550     1551       +1
Files Changed Coverage Δ
optuna/integration/_lightgbm_tuner/alias.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica Alnusjaponica marked this pull request as ready for review September 1, 2023 01:34
@toshihikoyanase
Copy link
Member

@not522 @HideakiImamura Could you review this PR, please?

not522
not522 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 added the bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. label Sep 7, 2023
@not522 not522 removed their assignment Sep 7, 2023
HideakiImamura
HideakiImamura approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 0ff4164 into optuna:master Sep 14, 2023
33 checks passed
@HideakiImamura HideakiImamura added this to the v3.4.0 milestone Sep 14, 2023
@Alnusjaponica Alnusjaponica deleted the fix-alias-handler branch October 26, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not522 not522 not522 approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@HideakiImamura HideakiImamura

Labels
bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Alnusjaponica @toshihikoyanase @not522 @HideakiImamura