Allow user-defined objective names in hyperparameter importance plots #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names can be specified via `optuna.study.Study.set_metric_names`. Additionally, `_get_importances_infos` has been factored out to DRY the code a bit.
github-actions
bot
added
the
optuna.visualization
Codecov Report
@@ Coverage Diff @@
## master #4986 +/- ##
==========================================
- Coverage 89.49% 89.48% -0.01%
==========================================
Files 202 202
Lines 14910 14938 +28
==========================================
+ Hits 13343 13368 +25
- Misses 1567 1570 +3
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
not522
added
the
feature
|
@HideakiImamura @Alnusjaponica Could you review this PR? |
| specific_create_study: Callable[[], Study], objective_names: list[str] | ||
| ) -> None: | ||
| study = specific_create_study() | ||
| study.set_metric_names(objective_names) |
There was a problem hiding this comment.
How about testing the case of not setting the metric names?
HideakiImamura
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4895. Names can be specified via
optuna.study.Study.set_metric_names. Additionally,_get_importances_infoshas been factored out to DRY the code a bit.Description of the changes
study.metric_namesinplot_param_importancesto derive custom objective names._get_importances_infosto DRY the code.Examples