Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CPU version of PyTorch in Docker image #5019

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Oct 11, 2023

Motivation

Currently the installed PyTorch wheel package in Docker image is different with tests-integration action.

  • Dockerfile:
    pip install ${PIP_OPTIONS} -e '.[benchmark, checking, document, integration, optional, test]' -f https://download.pytorch.org/whl/torch_stable.html; \
  • tests-integration:
    pip install --progress-bar off .[integration] --extra-index-url https://download.pytorch.org/whl/cpu

Description of the changes

Change the PyTorch wheel package installed in Docker image.

@c-bata c-bata added the CI Continuous integration. label Oct 11, 2023
@c-bata
Copy link
Member Author

c-bata commented Oct 11, 2023

@not522 Could you review this PR? I think this can be merged with just your approval.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #5019 (66a9a0a) into master (ab87e40) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5019      +/-   ##
==========================================
+ Coverage   89.36%   89.37%   +0.01%     
==========================================
  Files         203      203              
  Lines       15046    15046              
==========================================
+ Hits        13446    13448       +2     
+ Misses       1600     1598       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Build Docker Image / dockerimage (3.7, dev) will fail, but #5009 addresses this issue.

@not522 not522 added this to the v3.4.0 milestone Oct 11, 2023
@not522 not522 merged commit 5825125 into optuna:master Oct 11, 2023
42 of 43 checks passed
@c-bata c-bata deleted the use-torch-whl-cpu branch October 11, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants