Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to fix the installation and integration #5126

Merged
merged 2 commits into from Nov 22, 2023

Conversation

HideakiImamura
Copy link
Member

Motivation

I will correct several stale contents in Optuna's README.md. Specifically, I have amended it to place the installation section towards the beginning. Also, the initial part of the integration description was primarily about pruning, but the current integration encompasses various elements, so I have revised that part as well.

Description of the changes

  • Update README.md

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b5115) 89.31% compared to head (8f911e7) 89.32%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5126   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files         205      205           
  Lines       15188    15188           
=======================================
+ Hits        13565    13566    +1     
+ Misses       1623     1622    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 removed their assignment Nov 21, 2023
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
I left a minor comment")

README.md Outdated Show resolved Hide resolved
@HideakiImamura
Copy link
Member Author

@nabenabe0928 Thank you for your reviews. PTAL.

@nabenabe0928 nabenabe0928 removed their assignment Nov 21, 2023
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM:)

@not522 not522 merged commit 8ae0bd0 into optuna:master Nov 22, 2023
32 checks passed
@not522 not522 added the document Documentation related. label Nov 22, 2023
@not522 not522 added this to the v3.5.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants