Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Checks(integration) failure #5167

Merged
merged 1 commit into from Dec 26, 2023

Conversation

Alnusjaponica
Copy link
Collaborator

@Alnusjaponica Alnusjaponica commented Dec 26, 2023

Motivation

Fix Checks(integration) failure
https://github.com/optuna/optuna/actions/runs/7324844916/job/19948788224

Description of the changes

Update type hint for items of lightgmb.callback.CallbackEnv.evaluation_result_list, as updated by microsoft/LightGBM#6048. See Alnusjaponica#29 for the CI result.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Dec 26, 2023
@Alnusjaponica Alnusjaponica marked this pull request as ready for review December 26, 2023 04:09
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@not522 not522 added the code-fix Change that does not change the behavior, such as code refactoring. label Dec 26, 2023
@not522 not522 merged commit a8e6ead into optuna:master Dec 26, 2023
21 of 22 checks passed
@Alnusjaponica Alnusjaponica deleted the fix-checks-integration branch December 26, 2023 04:35
@not522 not522 added this to the v3.6.0 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants