New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a super quick f-ANOVA algorithm named PED-ANOVA #5212
Add a super quick f-ANOVA algorithm named PED-ANOVA #5212
Conversation
* Separate a file for efficient Parzen estimator * Raise value error when there are 2< samples better than baseline * Fix an import error and remove zero weights from Parzen estimator * Rename step to n_steps * Add a small number to categorical weights to avoid numerical errors * Rename efficient pe to scott pe * Add documentation for PED-ANOVA * Keep only quantile filters for now
It is just a quick note; I wrote a simple example code and confirmed that the current PR functions as expected.
|
ed635c1
to
3d17362
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5212 +/- ##
==========================================
- Coverage 89.38% 89.37% -0.01%
==========================================
Files 206 209 +3
Lines 15097 13119 -1978
==========================================
- Hits 13494 11725 -1769
+ Misses 1603 1394 -209 ☔ View full report in Codecov by Sentry. |
c0f7c93
to
96e6fba
Compare
7b75dde
to
925b6dc
Compare
Add the documentation here. |
Followup: Add a tutorial of how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Almost, LGTM! I suggest a minor comment for the file name. PTAL.
tests/importance_tests/pedanova_tests/test_pedanova_evaluator.py
Outdated
Show resolved
Hide resolved
Handle #5212 (comment) and experimental warning |
specified search_space. `evaluate_on_local=True` is especially useful when users | ||
modify search space during optimization. | ||
|
||
Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for your long running work! Let me merge this PR. |
Motivation
As f-ANOVA is quite slow when we have many trials, so I implemented a fast algorithm for f-ANOVA.
Paper: PED-ANOVA: Efficiently Quantifying Hyperparameter Importance in Arbitrary Subspaces
Description of the changes
I added a super quick f-ANOVA algorithm.
I compared the runtimes of PED-ANOVA with the Cython implementation of f-ANOVA: