Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime start during a trial #523

Merged
merged 4 commits into from
Sep 14, 2019

Conversation

tanapiyo
Copy link
Contributor

add datetime_start function to Trial class

optuna/trial.py Outdated Show resolved Hide resolved
@sile sile added this to the v0.17.0 milestone Sep 14, 2019
@sile sile added the enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. label Sep 14, 2019
Copy link
Member

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


Returns:
Datetime where the :class:`~optuna.trial.Trial` started.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with most of other methods, please add an empty line after the docstring.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll address this in a followup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Change that does not break compatibility and not affect public interfaces, but improves performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants