Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the old example directory #5244

Merged
merged 1 commit into from Feb 13, 2024

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Feb 12, 2024

Motivation

optuna/examples does not provide enough info.

Description of the changes

Replace optuna/exmaples with optuna-examples.

@nzw0301 nzw0301 added the document Documentation related. label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f70eb2) 89.88% compared to head (64e6378) 89.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5244   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files         213      213           
  Lines       14004    14004           
=======================================
  Hits        12587    12587           
  Misses       1417     1417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura
Copy link
Member

Thanks for the PR. Let me merge this PR with my one approval, since this is obviously correct.

@HideakiImamura HideakiImamura merged commit 094ea9b into optuna:master Feb 13, 2024
23 checks passed
@HideakiImamura HideakiImamura added this to the v3.6.0 milestone Feb 13, 2024
@nzw0301 nzw0301 deleted the fix-003-text-to-example branch February 13, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants